From dev-return-3113-archive-asf-public=cust-asf.ponee.io@singa.incubator.apache.org Fri Aug 2 01:42:55 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id B24C5180644 for ; Fri, 2 Aug 2019 03:42:54 +0200 (CEST) Received: (qmail 57513 invoked by uid 500); 2 Aug 2019 01:42:54 -0000 Mailing-List: contact dev-help@singa.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@singa.incubator.apache.org Delivered-To: mailing list dev@singa.incubator.apache.org Received: (qmail 57502 invoked by uid 99); 2 Aug 2019 01:42:53 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Aug 2019 01:42:53 +0000 From: GitBox To: dev@singa.apache.org Subject: [GitHub] [incubator-singa] nudles commented on a change in pull request #492: Make singa use multiple memory pools Message-ID: <156471017321.27136.12773332623287162784.gitbox@gitbox.apache.org> Date: Fri, 02 Aug 2019 01:42:53 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit nudles commented on a change in pull request #492: Make singa use multiple memory pools URL: https://github.com/apache/incubator-singa/pull/492#discussion_r309955217 ########## File path: src/core/memory/memory.cc ########## @@ -39,12 +39,10 @@ CnMemPool::CnMemPool(int numDevices, size_t init_size, size_t max_size) { conf_.add_device(i); conf_.set_init_size(init_size); conf_.set_max_size(max_size); - CHECK_LT(++pool_count, 2) << "CnMemPool must be used as a singleton."; Review comment: must it be a singleton? can we have a pool per GPU? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services