From dev-return-3107-archive-asf-public=cust-asf.ponee.io@singa.incubator.apache.org Thu Aug 1 15:37:43 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 284ED180644 for ; Thu, 1 Aug 2019 17:37:43 +0200 (CEST) Received: (qmail 83536 invoked by uid 500); 1 Aug 2019 15:37:42 -0000 Mailing-List: contact dev-help@singa.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@singa.incubator.apache.org Delivered-To: mailing list dev@singa.incubator.apache.org Received: (qmail 83525 invoked by uid 99); 1 Aug 2019 15:37:42 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Aug 2019 15:37:42 +0000 From: GitBox To: dev@singa.apache.org Subject: [GitHub] [incubator-singa] joddiy commented on a change in pull request #480: SINGA-474 ELU operator Message-ID: <156467386244.22988.2518759153999053594.gitbox@gitbox.apache.org> Date: Thu, 01 Aug 2019 15:37:42 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit joddiy commented on a change in pull request #480: SINGA-474 ELU operator URL: https://github.com/apache/incubator-singa/pull/480#discussion_r309687031 ########## File path: python/singa/autograd.py ########## @@ -358,6 +358,48 @@ def relu(x): return ReLU()(x)[0] +class Elu(Operation): + def __init__(self,alpha=1): + super(Elu, self).__init__() + self.alpha=alpha + + def forward(self, x): + """Do forward propgation. + Store the x if requires gradient. + Args: + x (CTensor): matrix + Returns: + a CTensor for the result + """ + #f(x) = alpha * (exp(x) - 1.) for x < 0, f(x) = x for x >= 0 + if training: + self.input = x + x1 = singa.LTFloat(x, 0.0) + x1 = singa.__mul__(x, x1) + x1 = singa.SubFloat(singa.Exp(x1),self.alpha) + x2 = singa.ReLU(x) + x1 = singa.__add__(x1, x2) + return x1 Review comment: It's a little weird to call ReLU here, can we implement it directly? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services