singa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-singa] moazreyad commented on a change in pull request #504: SINGA-481 Reconsturct soonx
Date Tue, 13 Aug 2019 08:24:04 GMT
moazreyad commented on a change in pull request #504: SINGA-481 Reconsturct soonx
URL: https://github.com/apache/incubator-singa/pull/504#discussion_r313273313
 
 

 ##########
 File path: test/python/test_onnx.py
 ##########
 @@ -0,0 +1,202 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+# =============================================================================
+
+import unittest
+from builtins import str
+
+from singa import tensor
+from singa import singa_wrap as singa
+from singa import autograd
+from singa import sonnx
+
+import onnx
+from onnx import (defs, checker, helper, numpy_helper, mapping,
+                  ModelProto, GraphProto, NodeProto, AttributeProto, TensorProto, OperatorSetIdProto)
+from onnx.helper import make_tensor, make_tensor_value_info, make_node, make_graph
+
+from cuda_helper import gpu_dev, cpu_dev
+
+import numpy as np
+
+autograd.training = True
+
+
+class TestPythonOnnxFrontend(unittest.TestCase):
+
 
 Review comment:
   > They haven't tested the frontend part.
   
   Yes, they don't test the frontend part because it is _backend_ test. 
   
   I think we should separate the backend test from the frontend test. The backend test must
be done using the standard onnx test (onnx.backend.test.BackendTest) similar to [this pull
request](https://github.com/apache/incubator-singa/pull/462). 
   
   Otherwise, we can not claim that SINGA implements ONNX backend if the standard [ONNX backend
test fails](https://issues.apache.org/jira/projects/SINGA/issues/SINGA-458). We can not ignore
the standard test and create our own test that passes successfully while the standard ONNX
test fails.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message