singa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module
Date Wed, 31 Jul 2019 10:20:28 GMT
chrishkchris commented on a change in pull request #468: Distributted module
URL: https://github.com/apache/incubator-singa/pull/468#discussion_r309144703
 
 

 ##########
 File path: src/CMakeLists.txt
 ##########
 @@ -36,6 +36,9 @@ AUX_SOURCE_DIRECTORY(core/scheduler core_source)
 AUX_SOURCE_DIRECTORY(core/tensor core_source)
 LIST(APPEND singa_sources ${core_source})
 
 
 Review comment:
   Changed the files cmake/Dependencies.cmake and src/CMakeLists.txt 
   Can use cmake -DUSE_DIST=ON to turn on the distributed module
   
   However, there are some bugs (mainly segmentation fault) if I add the #ifdef USE_DIST in
the files communicator.h and communicator.cc 
   I will update other files as well (e.g. #cmakedefine and #if USE_DIST etc. in many files)
when I successfully remove the bug.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message