singa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-singa] nudles commented on a change in pull request #493: SINGA-473 Autograd Trigonometry: Backward Test
Date Tue, 30 Jul 2019 14:04:37 GMT
nudles commented on a change in pull request #493: SINGA-473 Autograd Trigonometry: Backward
Test
URL: https://github.com/apache/incubator-singa/pull/493#discussion_r308740781
 
 

 ##########
 File path: test/python/test_operation.py
 ##########
 @@ -65,6 +65,17 @@ def prepare_inputs_targets_for_rnn_test():
     targets = [t0, t1, t2]
     return inputs, targets, h0
 
+def numpy_unary_ops_backward(func, x, dy, h=0.0005):
 
 Review comment:
   This is not correct.
   You can either use this [one](http://cs231n.github.io/optimization-1/#gradcompute), or
compute the gradient explicitly, e.g., gradient of cos() is sin()

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message