From dev-return-2721-archive-asf-public=cust-asf.ponee.io@singa.incubator.apache.org Thu Apr 4 04:50:36 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D4F5E18067E for ; Thu, 4 Apr 2019 06:50:35 +0200 (CEST) Received: (qmail 80647 invoked by uid 500); 4 Apr 2019 04:50:34 -0000 Mailing-List: contact dev-help@singa.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@singa.incubator.apache.org Delivered-To: mailing list dev@singa.incubator.apache.org Received: (qmail 80632 invoked by uid 99); 4 Apr 2019 04:50:34 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Apr 2019 04:50:34 +0000 From: GitBox To: dev@singa.apache.org Subject: [GitHub] [incubator-singa] nudles commented on a change in pull request #445: SINGA-433 updated documentation about docker, dockerfile for consitent, cudnn version in dockerfile Message-ID: <155435343377.5424.12748046023726642082.gitbox@gitbox.apache.org> Date: Thu, 04 Apr 2019 04:50:33 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit nudles commented on a change in pull request #445: SINGA-433 updated documentation about docker, dockerfile for consitent, cudnn version in dockerfile URL: https://github.com/apache/incubator-singa/pull/445#discussion_r272016433 ########## File path: cmake/Dependencies.cmake ########## @@ -144,9 +144,8 @@ ENDIF() IF(USE_MKLDNN) FIND_PATH(MKLDNN_INCLUDE_DIR NAME "mkldnn.hpp" PATHS "$ENV{CMAKE_INCLUDE_PATH}") - FIND_LIBRARY(MKLDNN_LIBRARIES NAME "libmkldnn.so" PATHS "$ENV{CMAKE_LIBRARY_PATH}") - FIND_LIBRARY(MKLML_LIBRARIES NAME "libmklml_intel.so" PATHS "$ENV{CMAKE_LIBRARY_PATH}") Review comment: I meant the test in ubuntu docker. I will do the test on macos. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services