From dev-return-2619-archive-asf-public=cust-asf.ponee.io@singa.incubator.apache.org Wed Mar 13 02:38:18 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2A565180763 for ; Wed, 13 Mar 2019 03:38:18 +0100 (CET) Received: (qmail 72089 invoked by uid 500); 13 Mar 2019 02:38:17 -0000 Mailing-List: contact dev-help@singa.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@singa.incubator.apache.org Delivered-To: mailing list dev@singa.incubator.apache.org Received: (qmail 72069 invoked by uid 99); 13 Mar 2019 02:38:17 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Mar 2019 02:38:17 +0000 From: GitBox To: dev@singa.apache.org Subject: [GitHub] [incubator-singa] ShichengChen commented on a change in pull request #416: singa-onnx Message-ID: <155244469650.28206.9311192424884738762.gitbox@gitbox.apache.org> Date: Wed, 13 Mar 2019 02:38:16 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ShichengChen commented on a change in pull request #416: singa-onnx URL: https://github.com/apache/incubator-singa/pull/416#discussion_r264956297 ########## File path: python/singa/autograd.py ########## @@ -614,10 +682,28 @@ def __call__(self, x): y = add_bias(y, self.b, axis=0) return y + def get_params(self): + if self.bias: + return {'W': self.W, 'b': self.b} + else: + return {'W': self.W} + + def set_params(self, **parameters): Review comment: no, I will not use this function ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services