From dev-return-2610-archive-asf-public=cust-asf.ponee.io@singa.incubator.apache.org Mon Mar 11 15:36:04 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id C5021180784 for ; Mon, 11 Mar 2019 16:36:03 +0100 (CET) Received: (qmail 53908 invoked by uid 500); 11 Mar 2019 15:36:02 -0000 Mailing-List: contact dev-help@singa.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@singa.incubator.apache.org Delivered-To: mailing list dev@singa.incubator.apache.org Received: (qmail 53890 invoked by uid 99); 11 Mar 2019 15:36:02 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Mar 2019 15:36:02 +0000 From: GitBox To: dev@singa.apache.org Subject: [GitHub] [incubator-singa] nudles commented on a change in pull request #416: singa-onnx Message-ID: <155231856235.26800.49332484535001073.gitbox@gitbox.apache.org> Date: Mon, 11 Mar 2019 15:36:02 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit nudles commented on a change in pull request #416: singa-onnx URL: https://github.com/apache/incubator-singa/pull/416#discussion_r264291619 ########## File path: python/singa/sonnx.py ########## @@ -258,8 +258,8 @@ def to_onnx_model(inputs, y, model_name='sonnx'): dependency = autograd.infer_dependency(y.creator) ready = deque([y.creator]) - def output_name(op): - return '{}'.format(op.name) + def output_name(op,extra=''): + return '{}'.format(op.name+str(extra)) Review comment: extra is a str? then why do you the type conversion? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services