From dev-return-2600-archive-asf-public=cust-asf.ponee.io@singa.incubator.apache.org Mon Mar 11 06:26:52 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id E57CA180763 for ; Mon, 11 Mar 2019 07:26:51 +0100 (CET) Received: (qmail 69992 invoked by uid 500); 11 Mar 2019 06:26:51 -0000 Mailing-List: contact dev-help@singa.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@singa.incubator.apache.org Delivered-To: mailing list dev@singa.incubator.apache.org Received: (qmail 69979 invoked by uid 99); 11 Mar 2019 06:26:50 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Mar 2019 06:26:50 +0000 From: GitBox To: dev@singa.apache.org Subject: [GitHub] [incubator-singa] ShichengChen commented on a change in pull request #416: singa-onnx Message-ID: <155228561034.9348.11106546734934347514.gitbox@gitbox.apache.org> Date: Mon, 11 Mar 2019 06:26:50 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ShichengChen commented on a change in pull request #416: singa-onnx URL: https://github.com/apache/incubator-singa/pull/416#discussion_r264102485 ########## File path: python/singa/tensor.py ########## @@ -87,10 +87,10 @@ class Tensor(object): grad but not store grad; But if a tensor stores grad then it must require grad. ''' - + tensor_count = 0 Review comment: `if name is None: self.name = 'Dummy#{}'.format(Tensor.tensor_count) Tensor.tensor_count += 1 else: self.name = name` add default name, we did not have self.name before, so i added it ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services