singa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-singa] ShichengChen commented on a change in pull request #416: singa-onnx
Date Tue, 12 Mar 2019 05:24:56 GMT
ShichengChen commented on a change in pull request #416: singa-onnx
URL: https://github.com/apache/incubator-singa/pull/416#discussion_r264525378
 
 

 ##########
 File path: python/singa/sonnx.py
 ##########
 @@ -258,8 +258,8 @@ def to_onnx_model(inputs, y, model_name='sonnx'):
     dependency = autograd.infer_dependency(y.creator)
     ready = deque([y.creator])
 
-    def output_name(op):
-        return '{}'.format(op.name)
+    def output_name(op,extra=''):
+        return '{}'.format(op.name+str(extra))
 
 Review comment:
   default is string, but if pass int to the function, it can convert to string automatically

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message