Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 303BA200C3A for ; Thu, 16 Mar 2017 07:57:46 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 2EDE3160B78; Thu, 16 Mar 2017 06:57:46 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7962D160B7A for ; Thu, 16 Mar 2017 07:57:45 +0100 (CET) Received: (qmail 16207 invoked by uid 500); 16 Mar 2017 06:57:44 -0000 Mailing-List: contact dev-help@singa.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@singa.incubator.apache.org Delivered-To: mailing list dev@singa.incubator.apache.org Received: (qmail 16197 invoked by uid 99); 16 Mar 2017 06:57:44 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Mar 2017 06:57:44 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 49109C18AF for ; Thu, 16 Mar 2017 06:57:44 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.451 X-Spam-Level: * X-Spam-Status: No, score=1.451 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_NEUTRAL=0.652] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 8eYjpXfVZApI for ; Thu, 16 Mar 2017 06:57:43 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 7CE9360FE2 for ; Thu, 16 Mar 2017 06:57:43 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id CA6DEE09D6 for ; Thu, 16 Mar 2017 06:57:42 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id BD258254BD for ; Thu, 16 Mar 2017 06:57:41 +0000 (UTC) Date: Thu, 16 Mar 2017 06:57:41 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: dev@singa.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SINGA-306) Write the definition of USE_GLOG into singa_config.h MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 16 Mar 2017 06:57:46 -0000 [ https://issues.apache.org/jira/browse/SINGA-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15927593#comment-15927593 ] ASF subversion and git services commented on SINGA-306: ------------------------------------------------------- Commit 0d4b97e0b0b65ccc7da72f541f1a58273d5f3bee in incubator-singa's branch refs/heads/master from [~zhongle] [ https://git-wip-us.apache.org/repos/asf?p=incubator-singa.git;h=0d4b97e ] Merge branch 'SINGA-306' > Write the definition of USE_GLOG into singa_config.h > ---------------------------------------------------- > > Key: SINGA-306 > URL: https://issues.apache.org/jira/browse/SINGA-306 > Project: Singa > Issue Type: Bug > Reporter: wangwei > Assignee: wangwei > > cmake defines USE_GLOG if glog is installed before compilation; > otherwise USE_GLOG is undefined. > however, this variable was not written into singa_config.h. Consequently, if singa is compiled with glog, and the application program is compiled with USE_GLOG undefined, then there would be linking error. This ticket fixes the error by writing USE_GLOG into the singa_config.h. -- This message was sent by Atlassian JIRA (v6.3.15#6346)