singa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Moaz Reyad (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (SINGA-273) Improve license and contributions
Date Thu, 24 Nov 2016 04:23:58 GMT

    [ https://issues.apache.org/jira/browse/SINGA-273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15692118#comment-15692118
] 

Moaz Reyad edited comment on SINGA-273 at 11/24/16 4:23 AM:
------------------------------------------------------------

Also in this ticket, we are going to fix the following license issues:

1. Doxyfile (https://github.com/apache/incubator-singa/blob/master/doc/Doxyfile) can not have
comments and must have Apache license header. See http://www.apache.org/legal/resolved.html

> Can we use Doxygen-generated config files?
> As long as the generated comments are removed from the Doxygen-generated files, these
files may be used. 

And see for example: https://github.com/apache/avro/blob/master/lang/c%2B%2B/Doxyfile

2. The Tinydir license can be safely removed from SINGA, because it is already included in
tinydir.h (https://github.com/apache/incubator-singa/blob/master/include/singa/utils/tinydir.h)
.

See https://github.com/cxong/tinydir :
> if you use tinydir you can comply by including tinydir.h

3. The LICENSE file says "SINGA bundles the following under BSD 3-clause license: cmake/Profobuf.cmake"

However, I could not find this file in SINGA. And CMake is not bundled with the project, so
the CMake license can be removed.

4. The distribution of BSD licensed source code requires that the license header is kept in
the source code files, but no need to mention it in the project license again.

See for example Caffe project that uses gtest :

https://github.com/BVLC/caffe/tree/master/src/gtest

So all these licenses can be safely removed from SINGA License :

SINGA bundles the following under New BSD license: test/gtest/*
SINGA bundles the following under New BSD license: tool/cpplint.py
SINGA bundles the following under New BSD license: src/python/swig/numpy.i

5. When using with CUDA, SINGA bundles the following under New BSD license: lib/cnmem/*
This cnmem does not exist in SINGA, so we can remove this license.


was (Author: moazreyad):
Also in this ticket, we are going to fix the following license issues:

1. Doxyfile (https://github.com/apache/incubator-singa/blob/master/doc/Doxyfile) can not have
comments and must have Apache license header. See http://www.apache.org/legal/resolved.html

> Can we use Doxygen-generated config files?
> As long as the generated comments are removed from the Doxygen-generated files, these
files may be used. 

And see for example: https://github.com/apache/avro/blob/master/lang/c%2B%2B/Doxyfile

2. The Tinydir license can be safely removed from SINGA, because it is already included in
tinydir.h (https://github.com/apache/incubator-singa/blob/master/include/singa/utils/tinydir.h)
.

See https://github.com/cxong/tinydir :
> if you use tinydir you can comply by including tinydir.h

3. The LICENSE file says "SINGA bundles the following under BSD 3-clause license: cmake/Profobuf.cmake"

However, I could not find this file in SINGA. And CMake is not bundled with the project, so
the CMake license can be removed.

> Improve license and contributions
> ---------------------------------
>
>                 Key: SINGA-273
>                 URL: https://issues.apache.org/jira/browse/SINGA-273
>             Project: Singa
>          Issue Type: Improvement
>            Reporter: Moaz Reyad
>            Priority: Minor
>
> The project needs a CONTRIBUTIONS.md file. (see https://github.com/blog/1184-contributing-guidelines).
> Also the third party licenses are mixed with the project license and this makes the project
license unclear. We may separate the third party license in the /thirdparty folder and keep
the Apache 2.0 license in the project root folder. 
> Finally, a license badge can be added to the README.md.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message