Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 2EC69200B96 for ; Thu, 6 Oct 2016 10:10:26 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 2D70F160AEE; Thu, 6 Oct 2016 08:10:26 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6A8F3160AAD for ; Thu, 6 Oct 2016 10:10:25 +0200 (CEST) Received: (qmail 2242 invoked by uid 500); 6 Oct 2016 08:10:24 -0000 Mailing-List: contact dev-help@singa.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@singa.incubator.apache.org Delivered-To: mailing list dev@singa.incubator.apache.org Received: (qmail 2228 invoked by uid 99); 6 Oct 2016 08:10:23 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Oct 2016 08:10:23 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 65EA51858CE for ; Thu, 6 Oct 2016 08:10:23 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -6.219 X-Spam-Level: X-Spam-Status: No, score=-6.219 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id wGlWS1_bJ_qb for ; Thu, 6 Oct 2016 08:10:22 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 4E8175FBDB for ; Thu, 6 Oct 2016 08:10:22 +0000 (UTC) Received: (qmail 1001 invoked by uid 99); 6 Oct 2016 08:10:21 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Oct 2016 08:10:21 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 121CA2C0D54 for ; Thu, 6 Oct 2016 08:10:21 +0000 (UTC) Date: Thu, 6 Oct 2016 08:10:21 +0000 (UTC) From: "wangwei (JIRA)" To: dev@singa.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Closed] (SINGA-152) Worker class needs to take greater responsibility of its setting up MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 06 Oct 2016 08:10:26 -0000 [ https://issues.apache.org/jira/browse/SINGA-152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wangwei closed SINGA-152. ------------------------- Resolution: Unresolved > Worker class needs to take greater responsibility of its setting up > ------------------------------------------------------------------- > > Key: SINGA-152 > URL: https://issues.apache.org/jira/browse/SINGA-152 > Project: Singa > Issue Type: Improvement > Environment: All > Reporter: Tan Li Boon > Labels: software-engineering > > Currently, the Driver class handles the setting up of the Worker objects in Driver::CreateWorkers(). However, much of the work done in that method should really be passed on the the Worker objects instead, likely in the Worker::Setup() method. > The rationale for this is that it is not really the responsibility of Driver to configure each and every Worker object; rather, it is sufficient to simply pass a job_conf to the Worker and let them set-up themselves. > A similar logic may be applied to the Server objects. > Doing so also allows us to easily configure each Worker on a per-Worker basis, simply by adding specifications into the job_conf object. -- This message was sent by Atlassian JIRA (v6.3.4#6332)