singa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Raunaq Abhyankar (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (SINGA-140) A bug in CollectAll() function when layers are unrolled in neuralnet
Date Wed, 30 Mar 2016 06:26:25 GMT

    [ https://issues.apache.org/jira/browse/SINGA-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15214299#comment-15214299
] 

Raunaq Abhyankar edited comment on SINGA-140 at 3/30/16 6:25 AM:
-----------------------------------------------------------------

Hi Kaiping,
I went through 'worker.cc', 'worker.h' and 'layer.h'. I feel the change suggested by you in
the description should do the trick!

I've sent in a PR.. Please review :)

Thanks!


was (Author: raunaq.abhyankar):
Hi Kaiping,
I went through 'worker.cc', 'worker.h' and 'layer.h'. I feel the change suggested by you in
the description should do the trick!

How do i send in a pull request? 

Thanks!

> A bug in CollectAll() function when layers are unrolled in neuralnet
> --------------------------------------------------------------------
>
>                 Key: SINGA-140
>                 URL: https://issues.apache.org/jira/browse/SINGA-140
>             Project: Singa
>          Issue Type: Bug
>            Reporter: Zheng Kaiping
>
> In SINGA_HOME/src/work.cc, in “int Worker::CollectAll(int step, NeuralNet* net){}”
function, the layers which are unrolled (except for the first one) should not collect parameters,
due to parameter sharing.
> Previous:
> if (layer->partition_id() == id_)
> Possible changes:
> if (layer->partition_id() == id_ && layer->unroll_index() == 0)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message