singa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SINGA-94) google::InitGoogleLogging() should be called in main() rather than inside Driver::Init()
Date Tue, 20 Oct 2015 10:26:27 GMT

    [ https://issues.apache.org/jira/browse/SINGA-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14964936#comment-14964936
] 

ASF subversion and git services commented on SINGA-94:
------------------------------------------------------

Commit 316c65bcd0ebcf6bce1ccf49049833a394f75fb3 in incubator-singa's branch refs/heads/master
from wang sheng
[ https://git-wip-us.apache.org/repos/asf?p=incubator-singa.git;h=316c65b ]

SINGA-94 Move call to google::InitGoogleLogging() from Driver::Init() to main()

merge to master branch


> google::InitGoogleLogging() should be called in main() rather than inside Driver::Init()
> ----------------------------------------------------------------------------------------
>
>                 Key: SINGA-94
>                 URL: https://issues.apache.org/jira/browse/SINGA-94
>             Project: Singa
>          Issue Type: Bug
>            Reporter: Yee Fan Tan
>
> google::InitGoogleLogging() should be called in main() rather than inside Driver::Init().
> Calling google::InitGoogleLogging() twice results in an error log "You called InitGoogleLogging()
twice!" and the program terminates from a CHECK condition. As such, it appears that google::InitGoogleLogging()
is not intended to be called inside a library, as it prevents the user of the library from
calling google::InitGoogleLogging() from his own main() function.
> This glog issue appears to confirm what I say: https://code.google.com/p/google-glog/issues/detail?id=113



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message