singa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "wangwei (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SINGA-84) Header Files Rearrange
Date Tue, 06 Oct 2015 12:52:26 GMT

    [ https://issues.apache.org/jira/browse/SINGA-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14944977#comment-14944977
] 

wangwei commented on SINGA-84:
------------------------------

Separating different layers into different files would avoid compiling a big file if we update
only a part of it.
May need to think about the names of the sub-folders and files, e.g., how about *src/neuralnet/neuron_layer/dropout.h*?
Typically, file and folder names do not have upper case letters.

> Header Files Rearrange
> ----------------------
>
>                 Key: SINGA-84
>                 URL: https://issues.apache.org/jira/browse/SINGA-84
>             Project: Singa
>          Issue Type: Improvement
>            Reporter: Wang Ji
>              Labels: patch
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> Rearrange the folders containing header files and split some of the header files into
separate folders to reduce coupling.
> 1. Create a new folder named "singa" as the parent directory of original headers. 
> Before:
>     "include/comm/..."
>     "include/gtest/..."
>     "include/driver.h"
>     "include/server.h"
>     ...
> After:
>     "include/singa/comm/..."
>     "include/singa/gtest/..."
>     "include/singa/driver.h"
>     "include/singa/server.h"
>     ...
> 2. Split header files from "include/neuralnet" into separate directory.
> #Split "include/nueralnet/loss_layer.h" into
>     "include/singa/nueralnet/loss/Softmax_loss_layer.h"
>     "include/singa/nueralnet/loss/Euclidean_loss_layer.h"
> #Split "include/nueralnet/neuron_layer.h" into
>     "include/singa/nueralnet/neuron/convolution_layer.h"
>     "include/singa/nueralnet/neuron/dropout_layer.h"
>     "include/singa/nueralnet/neuron/LRN_Layer.h"
>     "include/singa/nueralnet/neuron/pooling_Layer.h"
>     "include/singa/nueralnet/neuron/ReLU_Layer.h"
>     "include/singa/nueralnet/neuron/inner_product_Layer.h"
>     "include/singa/nueralnet/neuron/Tanh_Layer.h"
>     "include/singa/nueralnet/neuron/Sigmoid_Layer.h"
>     "include/singa/nueralnet/neuron/RBM_Layer.h"
>     "include/singa/nueralnet/neuron/RBM_visible_Layer.h"
>     "include/singa/nueralnet/neuron/RBM_hidden_Layer.h"
> #Split "include/nueralnet/input_layer.h" into
>     "include/singa/nueralnet/data/data_layer.h"
>         containing DataLayer, ShardDataLayer, LMDBDataLayer
>     "include/singa/nueralnet/data/parser_layer.h"
>         containing ParserLayer, LabelLayer, MnistLayer, RGBImageLayer 
>     "include/singa/nueralnet/data/prefetch_layer.h"
>         containing PrefetchLayer
> 3. Edit the inclusion of header files in corresponding source codes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message