singa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SINGA-21) Code Review
Date Wed, 23 Sep 2015 15:08:04 GMT

    [ https://issues.apache.org/jira/browse/SINGA-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14904618#comment-14904618
] 

ASF subversion and git services commented on SINGA-21:
------------------------------------------------------

Commit d3e1fca38b97e06ca113369d9a4f583750105a39 in incubator-singa's branch refs/heads/master
from wang sheng
[ https://git-wip-us.apache.org/repos/asf?p=incubator-singa.git;h=d3e1fca ]

SINGA-21 Code review 5

review server.h, server.cc
 - format code
 - remove thread_id field
 - rename variables
   nUpdate_ -> n_update_
   nPendingSync_ -> n_pending_sync_
 - fix a bug in HandleUpdate that using a *msg in a unknown state

TODO:
 - give each socket an unique id from cluster
 - buffer the un-processed message, intead of sending it back to stub


> Code Review
> -----------
>
>                 Key: SINGA-21
>                 URL: https://issues.apache.org/jira/browse/SINGA-21
>             Project: Singa
>          Issue Type: Task
>            Reporter: Sheng Wang
>            Assignee: Sheng Wang
>
> Clean the code for first release.
> Code style follows google c++ code style(https://google-styleguide.googlecode.com/svn/trunk/cppguide.html).
> Style check tool cpplint(http://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py)
is recommanded to help clean the code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message