singa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <>
Subject [jira] [Commented] (SINGA-21) Code Review
Date Fri, 04 Sep 2015 10:05:46 GMT


ASF subversion and git services commented on SINGA-21:

Commit 53de92b7fdf7e6eac58fe86663738377bedfbd36 in incubator-singa's branch refs/heads/master
from Wei Wang
[;h=53de92b ]

SINGA-21 Code review 4

categorize all layers into 5 types: input, loss, output, neuron and
connection layers.

remove all is_xxlayer functions. Worker::TrainOneBatch() and
Worker::TestOneBatch() have to check the layer type using other methods
(e.g., typeinfo from typeid()). A function like type_id() may be added to
return the type ID of a specific layer (which can be overridden by users).

tested with example cnn, mlp, and rbm models.

> Code Review
> -----------
>                 Key: SINGA-21
>                 URL:
>             Project: Singa
>          Issue Type: Task
>            Reporter: Sheng Wang
>            Assignee: Sheng Wang
> Clean the code for first release.
> Code style follows google c++ code style(
> Style check tool cpplint(
is recommanded to help clean the code.

This message was sent by Atlassian JIRA

View raw message