singa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SINGA-21) Code Review
Date Wed, 24 Jun 2015 13:36:05 GMT

    [ https://issues.apache.org/jira/browse/SINGA-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14599418#comment-14599418
] 

ASF subversion and git services commented on SINGA-21:
------------------------------------------------------

Commit cfde4718ad2e5544257056200003830568fb488c in incubator-singa's branch refs/heads/master
from wang wei
[ https://git-wip-us.apache.org/repos/asf?p=incubator-singa.git;h=cfde471 ]

SINGA-21 Code review - 2

Fix a bug caused by gflags version by adding a macro at main.cc to redefine the namespace
gflags=google
Update mnist/cifar10 example by adding a Makefile.example


> Code Review
> -----------
>
>                 Key: SINGA-21
>                 URL: https://issues.apache.org/jira/browse/SINGA-21
>             Project: Singa
>          Issue Type: Task
>            Reporter: Sheng Wang
>            Assignee: Sheng Wang
>
> Clean the code for first release.
> Code style follows google c++ code style(https://google-styleguide.googlecode.com/svn/trunk/cppguide.html).
> Style check tool cpplint(http://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py)
is recommanded to help clean the code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message