singa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From WANG Sheng <wan...@comp.nus.edu.sg>
Subject Re: Code Review
Date Mon, 22 Jun 2015 05:32:46 GMT
Hi all,

We have decided to follow the google c++ coding style.
In addition, a style-checking tool (cpplint) has been added into singa
repository.

Please check the following page to learn more details:
http://singa.incubator.apache.org/develop/contribute-code.html

Regards,

Sheng

On Thu, Jun 18, 2015 at 2:30 AM, Thejas Nair <thejas.nair@gmail.com> wrote:

> +1 having a code style is critical for open source projects with many
> contributors.
>
> Once a style is agreed upon, I think it should be added in
> http://singa.incubator.apache.org/develop/contribute-code.html .
>
> Committers reviewing the code should then check if it follows the style.
> If you can setup build tools to do style checks that would be even better.
>
>
> On Wed, Jun 17, 2015 at 1:35 AM, Wang Wei <wangwei@comp.nus.edu.sg> wrote:
> > Hi guys,
> >
> > Please do a code review when you are getting familiar with the current
> code.
> > It is important to make the code clean and easy to read for our first
> > release.
> >
> > We tried to follow the Google's C++ code style initially. But didn't do
> it
> > exactly.
> > If no other suggestions for the coding style, please still follow the
> > Google's style when doing the code review.
> > If you have any suggestions, please let us know.
> >
> > Thanks.
> >
> > regards,
> > Wei
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message