singa-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wang...@apache.org
Subject svn commit: r1690366 - /incubator/singa/site/trunk/content/markdown/develop/contribute-code.md
Date Sat, 11 Jul 2015 10:22:48 GMT
Author: wangwei
Date: Sat Jul 11 10:22:48 2015
New Revision: 1690366

URL: http://svn.apache.org/r1690366
Log:
add instructions for squash commit messages for a pull request

Modified:
    incubator/singa/site/trunk/content/markdown/develop/contribute-code.md

Modified: incubator/singa/site/trunk/content/markdown/develop/contribute-code.md
URL: http://svn.apache.org/viewvc/incubator/singa/site/trunk/content/markdown/develop/contribute-code.md?rev=1690366&r1=1690365&r2=1690366&view=diff
==============================================================================
--- incubator/singa/site/trunk/content/markdown/develop/contribute-code.md (original)
+++ incubator/singa/site/trunk/content/markdown/develop/contribute-code.md Sat Jul 11 10:22:48
2015
@@ -49,4 +49,12 @@ the work to the project under the projec
 to your new branch will be added to this pull request automatically by Github.
 
 * Wait for one committer to review the patch. If no conflicts, the committers will merge
it with
-the master branch. The merge should a) not use rebase b) disable fast forward merge c) put
the SINGA-xxx title in the first line of the merge commit message.
+the master branch. The merge should a) not use rebase b) disable fast forward merge c) check
the 
+commit message format and test the code/feature.
+
+* If there are too many small commit messages, you will be told to squash your commits into
fewer meaningful
+commits. If your commit message does not follow the format (i.e., SINGA-xxxx), you will be
told to
+reword your commit message. Both changes can be done using interactive git rebase. Once you
+get the commits corrected, push them to you own github again. Your pull request 
+will be automatically updated. For details, please refer to 
+[Rebase Pull Requests](https://github.com/edx/edx-platform/wiki/How-to-Rebase-a-Pull-Request).
\ No newline at end of file



Mime
View raw message