Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 398E2200BDA for ; Tue, 13 Dec 2016 18:05:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 38309160B32; Tue, 13 Dec 2016 17:05:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B3D19160B31 for ; Tue, 13 Dec 2016 18:04:59 +0100 (CET) Received: (qmail 84487 invoked by uid 500); 13 Dec 2016 17:04:59 -0000 Mailing-List: contact dev-help@shiro.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@shiro.apache.org Delivered-To: mailing list dev@shiro.apache.org Received: (qmail 84349 invoked by uid 99); 13 Dec 2016 17:04:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Dec 2016 17:04:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id C9B282C03E1 for ; Tue, 13 Dec 2016 17:04:58 +0000 (UTC) Date: Tue, 13 Dec 2016 17:04:58 +0000 (UTC) From: "Matt Traynham (JIRA)" To: dev@shiro.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SHIRO-605) ShiroWebModule creates out of order filter chain. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 13 Dec 2016 17:05:00 -0000 [ https://issues.apache.org/jira/browse/SHIRO-605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15745631#comment-15745631 ] Matt Traynham commented on SHIRO-605: ------------------------------------- [~bdemers] are you handling these bugs as well? > ShiroWebModule creates out of order filter chain. > ------------------------------------------------- > > Key: SHIRO-605 > URL: https://issues.apache.org/jira/browse/SHIRO-605 > Project: Shiro > Issue Type: Bug > Components: Integration: Guice > Affects Versions: 1.4.0-RC2 > Reporter: Matt Traynham > Assignee: Jared Bunting > Labels: easyfix > Fix For: 1.4.0 > > Attachments: 001.patch > > > The ShiroWebModule class is creating a randomly ordered filter chain, because it's using a HashMap instead of a LinkedHashMap. > The offending line is here: > https://github.com/apache/shiro/blob/master/support/guice/src/main/java/org/apache/shiro/guice/web/ShiroWebModule.java#L144 > This should be a LinkedHashMap to maintain original user order. > It does add the paths correctly: > https://github.com/apache/shiro/blob/master/support/guice/src/main/java/org/apache/shiro/guice/web/ShiroWebModule.java#L176 > And correctly returns to the FilterChainProvider: > https://github.com/apache/shiro/blob/master/support/guice/src/main/java/org/apache/shiro/guice/web/ShiroWebModule.java#L135 -- This message was sent by Atlassian JIRA (v6.3.4#6332)