shiro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SHIRO-605) ShiroWebModule creates out of order filter chain.
Date Tue, 13 Dec 2016 17:59:59 GMT

    [ https://issues.apache.org/jira/browse/SHIRO-605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15745776#comment-15745776
] 

ASF GitHub Bot commented on SHIRO-605:
--------------------------------------

GitHub user mtraynham opened a pull request:

    https://github.com/apache/shiro/pull/51

    SHIRO-605: Use LinkedHashMap to maintain order of filter chain

    Very simple change, just need to ensure filter chain order is maintained.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mtraynham/shiro SHIRO-605

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/shiro/pull/51.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #51
    
----
commit b7a132fca1e5c10601a4180fe6535399e33de84a
Author: Matt Traynham <mtraynham@tivo.com>
Date:   2016-12-13T17:58:24Z

    Use LinkedHashMap to maintain order of filter chain

----


> ShiroWebModule creates out of order filter chain.
> -------------------------------------------------
>
>                 Key: SHIRO-605
>                 URL: https://issues.apache.org/jira/browse/SHIRO-605
>             Project: Shiro
>          Issue Type: Bug
>          Components: Integration: Guice
>    Affects Versions: 1.4.0-RC2
>            Reporter: Matt Traynham
>            Assignee: Jared Bunting
>              Labels: easyfix
>             Fix For: 1.4.0
>
>         Attachments: 001.patch
>
>
> The ShiroWebModule class is creating a randomly ordered filter chain, because it's using
a HashMap instead of a LinkedHashMap.
> The offending line is here:
> https://github.com/apache/shiro/blob/master/support/guice/src/main/java/org/apache/shiro/guice/web/ShiroWebModule.java#L144
> This should be a LinkedHashMap to maintain original user order.
> It does add the paths correctly:
> https://github.com/apache/shiro/blob/master/support/guice/src/main/java/org/apache/shiro/guice/web/ShiroWebModule.java#L176
> And correctly returns to the FilterChainProvider:
> https://github.com/apache/shiro/blob/master/support/guice/src/main/java/org/apache/shiro/guice/web/ShiroWebModule.java#L135



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message