shiro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Demers (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SHIRO-605) ShiroWebModule creates out of order filter chain.
Date Tue, 13 Dec 2016 17:37:58 GMT

    [ https://issues.apache.org/jira/browse/SHIRO-605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15745721#comment-15745721
] 

Brian Demers commented on SHIRO-605:
------------------------------------

[~mtraynham] Thanks!  A PR would be great! I'll get it merged!

> ShiroWebModule creates out of order filter chain.
> -------------------------------------------------
>
>                 Key: SHIRO-605
>                 URL: https://issues.apache.org/jira/browse/SHIRO-605
>             Project: Shiro
>          Issue Type: Bug
>          Components: Integration: Guice
>    Affects Versions: 1.4.0-RC2
>            Reporter: Matt Traynham
>            Assignee: Jared Bunting
>              Labels: easyfix
>             Fix For: 1.4.0
>
>         Attachments: 001.patch
>
>
> The ShiroWebModule class is creating a randomly ordered filter chain, because it's using
a HashMap instead of a LinkedHashMap.
> The offending line is here:
> https://github.com/apache/shiro/blob/master/support/guice/src/main/java/org/apache/shiro/guice/web/ShiroWebModule.java#L144
> This should be a LinkedHashMap to maintain original user order.
> It does add the paths correctly:
> https://github.com/apache/shiro/blob/master/support/guice/src/main/java/org/apache/shiro/guice/web/ShiroWebModule.java#L176
> And correctly returns to the FilterChainProvider:
> https://github.com/apache/shiro/blob/master/support/guice/src/main/java/org/apache/shiro/guice/web/ShiroWebModule.java#L135



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message