shiro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Björn Raupach <raup...@me.com>
Subject Re: [jira] [Commented] (SHIRO-206) Support for JSF/Facelets
Date Fri, 04 Nov 2016 14:35:20 GMT
Alright, started to work on it here: https://github.com/raupachz/shiro/tree/wip-shiro-faces
<https://github.com/raupachz/shiro/tree/wip-shiro-faces>

Thank you Deluan for the work that is already done. :)

First impressions:
* shiro-faces depends on shiro-web. shiro-web does not specify its version of the Servlet
API. Is it Servlet API 3.1 (Java EE 7)? 
* There is also a project dependency on JDK 6. Java EE 7 depends on JDK 7. Are there plans
to upgrade shiro-web?

/Björn

> On 3 Nov 2016, at 17:52, Deluan Quintão <deluan@deluan.com> wrote:
> 
> Hi Björn, I'm not using this library anymore, so I encourage you to fork
> it, and send a pull request back if possible, so we keep the code unified
> in the github repo until it gets released with shiro.
> 
> I agree with Brian: we should keep the discussions here.
> 
> On Thu, 3 Nov 2016 at 12:43 Brian Demers <brian.demers@gmail.com> wrote:
> 
>> I'd say fork it on github, but keep the discussions here.
>> It's unreleased so updating the major versions should not be an issue.
>> 
>> On Thu, Nov 3, 2016 at 11:28 AM, Björn Raupach (JIRA) <jira@apache.org>
>> wrote:
>> 
>>> 
>>>    [ https://issues.apache.org/jira/browse/SHIRO-206?page=
>>> com.atlassian.jira.plugin.system.issuetabpanels:comment-
>>> tabpanel&focusedCommentId=15633101#comment-15633101 ]
>>> 
>>> Björn Raupach commented on SHIRO-206:
>>> -------------------------------------
>>> 
>>> Just playing around with it. Since it is not released yet we can do
>>> everyone a favour and patch it up to Java EE 7 support, JSF 2.2 and such.
>>> No need to support anything lower. What is the best place to talk about
>>> this? The dev mailing list?
>>> 
>>>> Support for JSF/Facelets
>>>> ------------------------
>>>> 
>>>>                Key: SHIRO-206
>>>>                URL: https://issues.apache.org/jira/browse/SHIRO-206
>>>>            Project: Shiro
>>>>         Issue Type: New Feature
>>>>         Components: shiro-faces, Web
>>>>   Affects Versions: 1.1.0, 1.2.0
>>>>        Environment: JSF 1.2 / Facelets 1.1.14
>>>>           Reporter: Deluan Quintao
>>>>            Fix For: 2.0.0
>>>> 
>>>>        Attachments: shiro-faces-jsf2.zip, shiro-faces-support.patch
>>>> 
>>>> 
>>>> The attached patch implements a new support module 'shiro-faces'  that
>>> implements a tag library compatible with Facelets, that can be used in
>> JSF
>>> 1.2 projects. The tags are based on the original JSP tags, available in
>> the
>>> web module.
>>> 
>>> 
>>> 
>>> --
>>> This message was sent by Atlassian JIRA
>>> (v6.3.4#6332)
>>> 
>> 


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message