Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id AF52C200B41 for ; Thu, 7 Jul 2016 20:13:13 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id AE2FB160A68; Thu, 7 Jul 2016 18:13:13 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 285CC160A4F for ; Thu, 7 Jul 2016 20:13:13 +0200 (CEST) Received: (qmail 21494 invoked by uid 500); 7 Jul 2016 18:13:11 -0000 Mailing-List: contact dev-help@shiro.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@shiro.apache.org Delivered-To: mailing list dev@shiro.apache.org Received: (qmail 21477 invoked by uid 99); 7 Jul 2016 18:13:11 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Jul 2016 18:13:11 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 09BC52C02A3 for ; Thu, 7 Jul 2016 18:13:11 +0000 (UTC) Date: Thu, 7 Jul 2016 18:13:11 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@shiro.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SHIRO-330) Refactor Cookie / Simple Cookie & Add Encrypted Cookie MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 07 Jul 2016 18:13:13 -0000 [ https://issues.apache.org/jira/browse/SHIRO-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15366530#comment-15366530 ] ASF GitHub Bot commented on SHIRO-330: -------------------------------------- Github user bdemers closed the pull request at: https://github.com/apache/shiro/pull/28 > Refactor Cookie / Simple Cookie & Add Encrypted Cookie > ------------------------------------------------------- > > Key: SHIRO-330 > URL: https://issues.apache.org/jira/browse/SHIRO-330 > Project: Shiro > Issue Type: New Feature > Components: Web > Affects Versions: 1.2.0 > Reporter: Allan Ditzel > Priority: Minor > Labels: patch, patch-with-test > Fix For: 1.3.0 > > Attachments: encrypted_cookie1.patch > > > The current Cookie/SimpleCookie mechanism blends usage and creational concerns, i.e. the cookie both holds state and is a factory, acting as a template to create new cookie instances. These concerns should be separated. > In addition, it would be nice to have an encrypted cookie mechanism. Attached there is a patch for an initial implementation of an encrypted cookie based on 1.2.0 code. It's been added to capture the intent behind the cookie and to quickly patch the code base with this functionality before refactoring in a future version. -- This message was sent by Atlassian JIRA (v6.3.4#6332)