Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4CD2B200B67 for ; Tue, 12 Jul 2016 00:19:13 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 4B76D160A78; Mon, 11 Jul 2016 22:19:13 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C1E03160A7D for ; Tue, 12 Jul 2016 00:19:12 +0200 (CEST) Received: (qmail 35091 invoked by uid 500); 11 Jul 2016 22:19:11 -0000 Mailing-List: contact dev-help@shiro.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@shiro.apache.org Delivered-To: mailing list dev@shiro.apache.org Received: (qmail 35027 invoked by uid 99); 11 Jul 2016 22:19:11 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Jul 2016 22:19:11 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 91CC82C02AE for ; Mon, 11 Jul 2016 22:19:11 +0000 (UTC) Date: Mon, 11 Jul 2016 22:19:11 +0000 (UTC) From: "Brian Demers (JIRA)" To: dev@shiro.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (SHIRO-84) Enhance SavedRequest MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 11 Jul 2016 22:19:13 -0000 [ https://issues.apache.org/jira/browse/SHIRO-84?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brian Demers updated SHIRO-84: ------------------------------ Fix Version/s: (was: 1.3.0) > Enhance SavedRequest > -------------------- > > Key: SHIRO-84 > URL: https://issues.apache.org/jira/browse/SHIRO-84 > Project: Shiro > Issue Type: Improvement > Components: Web > Affects Versions: 1.0.0 > Reporter: Les Hazlewood > Priority: Minor > > After reviewing SHIRO-82, it appears that we could do some more robust Request saving logic. After looking at Tomcat's FormAuthenticator source code [1] (matchRequest and restoreRequest methods), there are more things we can do to make our solution more capable, like saving Cookies and other request-related data. > [1] http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/authenticator/FormAuthenticator.java?revision=HEAD > We should enhance the current SavedRequest implementation based on similar logic found in the above Tomcat code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)