shiro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bdemers <>
Subject [GitHub] shiro pull request #24: WIP: CDI feature import SHIRO-337
Date Wed, 06 Jul 2016 16:53:35 GMT
GitHub user bdemers opened a pull request:

    WIP: CDI feature import SHIRO-337

    I spent about a day looking into this, the original code was pretty good, but I ran into
a few issues when adding a sample project 
    Added CDI [](support/cdi/
    Added TODO's:
    * [support/cdi](support/cdi/
    * [samples](samples/cdi/
    Comments above are just initial thoughts and are here to start discussion.
    @hwellmann, I know it has been a while since you looked into this, but your thoughts would
be appreciated 

You can merge this pull request into a Git repository by running:

    $ git pull cdi-import

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #24
commit daff202fe1a46141badcf73309d3237dcf4f8ef0
Author: Brian Demers <>
Date:   2016-07-05T19:35:35Z

    Initial CDI import

commit 8e40907d67e38b961ddffba7a2411bc8745f8139
Author: Brian Demers <>
Date:   2016-07-05T19:38:53Z

    renamed cdi packages after import

commit b806d61d40aad94db5e9f76b10e57d54cab8ba52
Author: Brian Demers <>
Date:   2016-07-05T20:14:46Z

    Replaced geronimo spec dependencies with javax equivalents

commit 4dfcbd0b770b2d45e8daf52f6ad80a26c9abb16b
Author: Brian Demers <>
Date:   2016-07-05T20:33:06Z

    Removed @author javadoc tags

commit 0200e716f2df8ad552bc852b356485696fae07a6
Author: Brian Demers <>
Date:   2016-07-05T21:00:42Z

    Updated license headers to match project

commit 8c380223fd8acc02f6d809a426e31079cd11c9c0
Author: Brian Demers <>
Date:   2016-07-06T16:34:32Z

    Attempting to add a CDI example from ops4j/org.ops4j.pax.shiro
    original sample:
    Added from:
    Added in support/cdi and samples/cdi with thoughts on the project


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message