shiro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Demers (JIRA)" <>
Subject [jira] [Updated] (SHIRO-501) Add ability to set system properties in shiro.ini
Date Tue, 12 Jul 2016 14:39:20 GMT


Brian Demers updated SHIRO-501:
    Fix Version/s:     (was: 1.3.0)

Current patch no longer applies (after recent code changes to the RefectionBuilder)

It looks like the equivalent hook would be in the `buildObjects` method.

That said, I'd like to hear other opinions about this.

Personally, I'm a +1 for this style of interpolation ${value}
I think the context should be a bit more flexible, SystemProperties, and any other Properties
a user wants to inject. (for example: SHIRO-445)

I also think we might need to pull in another dependency to deal with the actual interpolation
of strings (to handle cases like nested interpolation)

Which, leads me to my next question.  Shiro core only has a few dependencies:
+- org.slf4j:slf4j-api:jar:1.6.4:compile
\- commons-beanutils:commons-beanutils:jar:1.8.3:compile

So I wanted another opinion before brining in something like commons-lang3 for the `StrSubstitutor`

> Add ability to set system properties in shiro.ini
> -------------------------------------------------
>                 Key: SHIRO-501
>                 URL:
>             Project: Shiro
>          Issue Type: New Feature
>    Affects Versions: 1.2.3
>            Reporter: Johnathan James
>              Labels: patch
>         Attachments: SHIRO-501.patch
> Shiro should be able to inject values from system properties into the INI key value pairs.

This message was sent by Atlassian JIRA

View raw message