shiro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Demers (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (SHIRO-480) setTarget method in DomainPermission does not set targets
Date Wed, 06 Jul 2016 18:58:11 GMT

     [ https://issues.apache.org/jira/browse/SHIRO-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Brian Demers resolved SHIRO-480.
--------------------------------
       Resolution: Fixed
    Fix Version/s: 1.3.0

> setTarget method in DomainPermission does not set targets
> ---------------------------------------------------------
>
>                 Key: SHIRO-480
>                 URL: https://issues.apache.org/jira/browse/SHIRO-480
>             Project: Shiro
>          Issue Type: Bug
>          Components: Authorization (access control) 
>    Affects Versions: 1.2.2
>            Reporter: Bill Weiss
>            Priority: Minor
>             Fix For: 1.3.0
>
>
> The setTarget() method in org.apache.shiro.authz.permission.DomainPermission has an apparent
typo, or copy paste error:
> 133    protected void setTargets(Set<String> targets) {
> 134        this.targets = targets;
> 135        if (this.targets != null && this.targets.equals(targets)) {
> 136            return;
> 137        }
> 138        this.targets = targets;
> 139        setParts(domain, actions, targets);
> 140    }
> As you can see, line 134 is a duplicate of line 138 and will in all cases, except where
the argument targets is null, prevent execution from ever calling setParts() and functioning
properly.
> The work around for now is for classes extending DomainPermission to handle the call
to setParts() directly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message