shiro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "amit yatagiri (JIRA)" <j...@apache.org>
Subject [jira] [Created] (SHIRO-565) On Successful Login Shiro adds two response header values for the same remember-me cookie name.
Date Mon, 23 May 2016 10:10:13 GMT
amit yatagiri created SHIRO-565:
-----------------------------------

             Summary: On Successful Login Shiro adds two response header values for the same
remember-me cookie name.
                 Key: SHIRO-565
                 URL: https://issues.apache.org/jira/browse/SHIRO-565
             Project: Shiro
          Issue Type: Bug
    Affects Versions: 1.2.3
            Reporter: amit yatagiri


On successful login, shiro adds two cookie entries one with deleteMe as value and other with
the encrypted value.
Though delete-me value cookie has expired state, it should not be resent in the header. As
per the cookie spec, order of the response headers should not be relied upon.
class : AbstractRememberMeManager
method : 
public void onSuccessfulLogin(Subject subject, AuthenticationToken token, AuthenticationInfo
info) {
//always clear any previous identity:
forgetIdentity(subject);
//now save the new identity:
if (isRememberMe(token))
{ rememberIdentity(subject, token, info); }
else {
if (log.isDebugEnabled())
{ log.debug("AuthenticationToken did not indicate RememberMe is requested. " + "RememberMe
functionality will not be executed for corresponding account."); }
}
}
In the above code, forget identity happens every time. Better place is in the else condition(when
isNotRememberMe).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message