Mailing-List: contact dev-help@shiro.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@shiro.apache.org
Date: Fri, 18 Mar 2016 13:21:33 +0000 (UTC)
From: "Andreas Kohn (JIRA)" <jira@apache.org>
To: dev@shiro.apache.org
Message-ID: <JIRA.12951377.1458256334000.59361.1458307293612@Atlassian.JIRA>
In-Reply-To: <JIRA.12951377.1458256334000@Atlassian.JIRA>
References: <JIRA.12951377.1458256334000@Atlassian.JIRA>
 <JIRA.12951377.1458256334522@arcas>
Subject: [jira] [Commented] (SHIRO-562) WildcardPermission calls
 String.trim() twice in setParts()
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/SHIRO-562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15201459#comment-15201459 ] 

Andreas Kohn commented on SHIRO-562:
------------------------------------

Sounds reasonable, patch (if shiro wants to take it): https://github.com/Collaborne/shiro/commit/3661041b0ab6700fecfc6b6d989da95d2cc3c762

> WildcardPermission calls String.trim() twice in setParts()
> ----------------------------------------------------------
>
>                 Key: SHIRO-562
>                 URL: https://issues.apache.org/jira/browse/SHIRO-562
>             Project: Shiro
>          Issue Type: Improvement
>          Components: Authorization (access control) 
>    Affects Versions: 1.2.4
>         Environment: any
>            Reporter: Matt Bishop
>            Priority: Trivial
>
> WildcardPermission.setParts does this: 
> {quote}
>  if (wildcardString == null || wildcardString.trim().length() == 0) {
>             throw new IllegalArgumentException("Wildcard string cannot be null or empty. Make sure permission strings are properly formatted.");
>         }
>         wildcardString = wildcardString.trim();
> {quote}
> Given the frequency of the use of this method it would be better to capture the first trim().


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)