shiro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Bishop (JIRA)" <>
Subject [jira] [Created] (SHIRO-564) WildcardPermission case-insensitive makes parts collections twice
Date Mon, 21 Mar 2016 19:08:25 GMT
Matt Bishop created SHIRO-564:

             Summary: WildcardPermission case-insensitive makes parts collections twice
                 Key: SHIRO-564
             Project: Shiro
          Issue Type: Improvement
          Components: Authorization (access control) 
    Affects Versions: 1.2.4
         Environment: Any
            Reporter: Matt Bishop
            Priority: Trivial

WildcardPermissions have a caseSensitive flag that instructs the permission to ignore case
when comparing permissions. It's implementation of this feature is kinda wasteful because
it first parses the permission string into List<Set<String>> parts, THEN checks
the flag and then rebuilds the parts collections.

It might be faster to check the flag first, lowercase the permission string, then parse the
parts. This would save creating a whole bunch of extra HashSets and ArrayLists.

This message was sent by Atlassian JIRA

View raw message