shiro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jack Tan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SHIRO-224) Refactor Shiro's Filters to favor composition over inheritance where possible.
Date Wed, 05 Aug 2015 08:33:04 GMT

    [ https://issues.apache.org/jira/browse/SHIRO-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14655008#comment-14655008
] 

Jack Tan commented on SHIRO-224:
--------------------------------

Maybe Annotation is a better selection over inheritance.

> Refactor Shiro's Filters to favor composition over inheritance where possible.
> ------------------------------------------------------------------------------
>
>                 Key: SHIRO-224
>                 URL: https://issues.apache.org/jira/browse/SHIRO-224
>             Project: Shiro
>          Issue Type: Improvement
>          Components: Web
>            Reporter: Les Hazlewood
>             Fix For: 2.0.0
>
>
> Scheduling to 2.0 initially as this might be disruptive.
> Currently, to receive the benefits of the NameableFilter, OncePerRequestFilter, PathMatchingFilter,
etc, a user must subclass one of these classes.  It would be better to have a proxy of sorts
that performs these functions for any filter and wraps the 'real' target filter.  This way,
users' filter implementations do not need to be tightly coupled to Shiro's API.  This will
also enable these features for already existing filters so they don't need to be refactored
to subclass a Shiro class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message