shiro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stuart McCulloch (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (SHIRO-502) OSGi import of com.google.inject in shiro-guice has incorrect version range
Date Thu, 21 May 2015 21:09:18 GMT

    [ https://issues.apache.org/jira/browse/SHIRO-502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14555047#comment-14555047
] 

Stuart McCulloch edited comment on SHIRO-502 at 5/21/15 9:09 PM:
-----------------------------------------------------------------

Example patch which changes the guice import version range to at least 1.3 with no upper range.


was (Author: mcculls):
Example patch which changes the import version range to at least 1.3 with no upper range.

> OSGi import of com.google.inject in shiro-guice has incorrect version range
> ---------------------------------------------------------------------------
>
>                 Key: SHIRO-502
>                 URL: https://issues.apache.org/jira/browse/SHIRO-502
>             Project: Shiro
>          Issue Type: Bug
>          Components: Integration: Guice
>            Reporter: Stuart McCulloch
>            Assignee: Jared Bunting
>         Attachments: SHIRO-502.patch
>
>
> The guice project follows a relaxed* form of semantic versioning in its package exports.
So while the bundle version increases on each major release: 2, 3, 4 the exported package
version only increases the minor segment: 1.2, 1.3, 1.4 to reflect that the API is still binary
compatible - albeit with additional features.
> (* relaxed because the same version is applied to all packages in the bundle)
> This means that shiro-guice fails to resolve against the official guice bundle, because
guice 3 is exporting com.google.inject with a version "1.3", but shiro-guice is importing
com.google.inject with a range of "\[3, 4)"
> Solution is to either remove the version range on the import, or widen it to something
like "1.3" (ie. provide a lower bound, but not an upper bound).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message