shiro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Les Hazlewood (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SHIRO-498) ThreadLocal should not be created when not necessary
Date Sun, 12 Apr 2015 02:51:13 GMT

    [ https://issues.apache.org/jira/browse/SHIRO-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14491304#comment-14491304
] 

Les Hazlewood commented on SHIRO-498:
-------------------------------------

I'll try to apply the patch today.

> ThreadLocal should not be created when not necessary
> ----------------------------------------------------
>
>                 Key: SHIRO-498
>                 URL: https://issues.apache.org/jira/browse/SHIRO-498
>             Project: Shiro
>          Issue Type: Improvement
>    Affects Versions: 1.2.2
>            Reporter: Jochen Kemnade
>            Assignee: Kalle Korhonen
>              Labels: patch
>         Attachments: 0001-don-t-create-ThreadLocals-when-not-needed.patch
>
>
> org.apache.shiro.util.ThreadContext.getValue(Object) and org.apache.shiro.util.ThreadContext.remove(Object)
initialze the TheadLocal unnecessarily via initialValue(). Both methods should return without
creating the ThreadLocal to avoid potential memory leaks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message