Return-Path: X-Original-To: apmail-shiro-dev-archive@www.apache.org Delivered-To: apmail-shiro-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D927617D66 for ; Wed, 1 Oct 2014 20:04:34 +0000 (UTC) Received: (qmail 98010 invoked by uid 500); 1 Oct 2014 20:04:34 -0000 Delivered-To: apmail-shiro-dev-archive@shiro.apache.org Received: (qmail 97979 invoked by uid 500); 1 Oct 2014 20:04:34 -0000 Mailing-List: contact dev-help@shiro.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@shiro.apache.org Delivered-To: mailing list dev@shiro.apache.org Received: (qmail 97914 invoked by uid 99); 1 Oct 2014 20:04:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Oct 2014 20:04:34 +0000 Date: Wed, 1 Oct 2014 20:04:34 +0000 (UTC) From: "Les Hazlewood (JIRA)" To: dev@shiro.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SHIRO-332) Change access level of method 'isPermitted' in org.apache.shiro.realm.AuthorizingRealm (line 461) from private to protected MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SHIRO-332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14155397#comment-14155397 ] Les Hazlewood commented on SHIRO-332: ------------------------------------- I think we'd like to get a 1.2.4 patch release out next week if remotely possible. JavaOne is this week, so this week is too difficult. A 2.0 release might be more likely than a 1.3 release - not sure (maybe both). > Change access level of method 'isPermitted' in org.apache.shiro.realm.AuthorizingRealm (line 461) from private to protected > ------------------------------------------------------------------------------------------------------------------------------- > > Key: SHIRO-332 > URL: https://issues.apache.org/jira/browse/SHIRO-332 > Project: Shiro > Issue Type: Improvement > Components: Authorization (access control) > Affects Versions: 1.1.0 > Reporter: clifford harms > Priority: Minor > Labels: api-change, authorization, authorizing-realm > Fix For: 1.3.0 > > Original Estimate: 1h > Remaining Estimate: 1h > > In org.apache.shiro.realm.AuthorizingRealm, line 461, the method private boolean isPermitted(Permission permission, AuthorizationInfo info) should have its access level set to protected. This method is the ideal method to override If a developer wishes to change how a realm that extends AuthorizingRealm interacts with the AuthorizationInfo when permissions are checked. This is because all of the 'isPermitted' method overloads delegate the actual permission checking to this method. As the class stands now, all of the isPermitted overloads have to be re-implemented as overrides to Authorizing realm in order for the developer to safely change this behavior. -- This message was sent by Atlassian JIRA (v6.3.4#6332)