shiro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Les Hazlewood (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SHIRO-332) Change access level of method 'isPermitted' in org.apache.shiro.realm.AuthorizingRealm (line 461) from private to protected
Date Wed, 01 Oct 2014 20:04:34 GMT

    [ https://issues.apache.org/jira/browse/SHIRO-332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14155397#comment-14155397
] 

Les Hazlewood commented on SHIRO-332:
-------------------------------------

I think we'd like to get a 1.2.4 patch release out next week if remotely possible.  JavaOne
is this week, so this week is too difficult.  A 2.0 release might be more likely than a 1.3
release - not sure (maybe both).

> Change access level of method  'isPermitted' in  org.apache.shiro.realm.AuthorizingRealm
 (line 461)  from private to protected
> -------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SHIRO-332
>                 URL: https://issues.apache.org/jira/browse/SHIRO-332
>             Project: Shiro
>          Issue Type: Improvement
>          Components: Authorization (access control) 
>    Affects Versions: 1.1.0
>            Reporter: clifford harms
>            Priority: Minor
>              Labels: api-change, authorization, authorizing-realm
>             Fix For: 1.3.0
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> In org.apache.shiro.realm.AuthorizingRealm, line 461, the method     private boolean
isPermitted(Permission permission, AuthorizationInfo info)    should have its access level
set to protected.  This method is the ideal method to override If a developer wishes to change
how a  realm that extends AuthorizingRealm interacts with the AuthorizationInfo when permissions
are checked.  This is because all of the  'isPermitted' method overloads delegate the actual
permission checking to this method.  As the class stands now, all of the isPermitted overloads
have to be  re-implemented as overrides to Authorizing realm in order for the developer to
safely change this behavior. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message