shiro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Terry Chia (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SHIRO-290) Create a BCrypt Hash implementation
Date Sat, 20 Jul 2013 03:08:48 GMT

    [ https://issues.apache.org/jira/browse/SHIRO-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13714315#comment-13714315
] 

Terry Chia commented on SHIRO-290:
----------------------------------

I have looked closer at jBCrypt and the unit test included in the source code.[1]

The unit test asserts the hashing functions against well known test vectors for Bcrypt which
is being used to validate other known implementations of the algorithm including Bcrypt.NET
[2] and py-bcrypt [3]. This gives me confidence that jBCrypt has been implemented correctly
especially since py-bcrypt is just a python wrapper around the original OpenBSD code. 

If you are agreeable with this, I will take a closer look at your recommendations of writing
a PasswordService implementation that delegates to jBCrypt.

[1] https://github.com/jeremyh/jBCrypt/blob/master/src/test/java/org/mindrot/TestBCrypt.java
[2] https://bitbucket.org/vadim/bcrypt.net/src/464c41416dc9/BCrypt.Net.Test/TestBCrypt.cs
[3] https://code.google.com/p/py-bcrypt/source/browse/test/test.py
                
> Create a BCrypt Hash implementation
> -----------------------------------
>
>                 Key: SHIRO-290
>                 URL: https://issues.apache.org/jira/browse/SHIRO-290
>             Project: Shiro
>          Issue Type: New Feature
>          Components: Cryptography & Hashing
>            Reporter: Les Hazlewood
>            Assignee: Les Hazlewood
>             Fix For: 1.3.0
>
>
> Enable BCrypt hashing for those that wish to use it.  The following code can probably
be modified and included (it is a BSD license):
> http://www.mindrot.org/projects/jBCrypt/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message