shiro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Les Hazlewood (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (SHIRO-332) Change access level of method 'isPermitted' in org.apache.shiro.realm.AuthorizingRealm (line 461) from private to protected
Date Fri, 28 Dec 2012 18:08:12 GMT

     [ https://issues.apache.org/jira/browse/SHIRO-332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Les Hazlewood resolved SHIRO-332.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 1.3.0

Changed visibility from private to protected for the following two methods:

boolean isPermitted(Permission permission, AuthorizationInfo info)
Collection<Permission> getPermissions(AuthorizationInfo info)
                
> Change access level of method  'isPermitted' in  org.apache.shiro.realm.AuthorizingRealm
 (line 461)  from private to protected
> -------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SHIRO-332
>                 URL: https://issues.apache.org/jira/browse/SHIRO-332
>             Project: Shiro
>          Issue Type: Improvement
>          Components: Authorization (access control) 
>    Affects Versions: 1.1.0
>            Reporter: clifford harms
>            Priority: Minor
>              Labels: api-change, authorization, authorizing-realm
>             Fix For: 1.3.0
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> In org.apache.shiro.realm.AuthorizingRealm, line 461, the method     private boolean
isPermitted(Permission permission, AuthorizationInfo info)    should have its access level
set to protected.  This method is the ideal method to override If a developer wishes to change
how a  realm that extends AuthorizingRealm interacts with the AuthorizationInfo when permissions
are checked.  This is because all of the  'isPermitted' method overloads delegate the actual
permission checking to this method.  As the class stands now, all of the isPermitted overloads
have to be  re-implemented as overrides to Authorizing realm in order for the developer to
safely change this behavior. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message