shiro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jared Bunting (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SHIRO-368) DomainPermission(string, string) constructor sets targets to the same value as actions
Date Sat, 21 Jul 2012 23:51:34 GMT

    [ https://issues.apache.org/jira/browse/SHIRO-368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13419977#comment-13419977
] 

Jared Bunting commented on SHIRO-368:
-------------------------------------

I'm adding this patch and test.  However, I've modified all of the assertions in the test
to be more comprehensive than just "assertTrue".
                
> DomainPermission(string, string) constructor sets targets to the same value as actions
> --------------------------------------------------------------------------------------
>
>                 Key: SHIRO-368
>                 URL: https://issues.apache.org/jira/browse/SHIRO-368
>             Project: Shiro
>          Issue Type: Bug
>          Components: Authorization (access control) 
>    Affects Versions: 1.2.0
>         Environment: Windows XP SP3, Intel Core2 Duo
>            Reporter: Ben Johnson
>            Priority: Minor
>         Attachments: DomainPermission.java, DomainPermission.patch, DomainPermissionTest.java
>
>
> The DomainPermission(string, string) constructor incorrectly sets the 'targets' field
to the value supplied for 'actions':
> 055        public DomainPermission(String actions, String targets) {
> 056            this.domain = getDomain(getClass());
> 057            this.actions = StringUtils.splitToSet(actions, SUBPART_DIVIDER_TOKEN);
> 058            this.targets = StringUtils.splitToSet(actions, SUBPART_DIVIDER_TOKEN);
> 059            encodeParts(this.domain, actions, targets);
> 060        }

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message