Return-Path: X-Original-To: apmail-shiro-dev-archive@www.apache.org Delivered-To: apmail-shiro-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 93EEE9A9F for ; Wed, 6 Jun 2012 19:12:24 +0000 (UTC) Received: (qmail 77727 invoked by uid 500); 6 Jun 2012 19:12:24 -0000 Delivered-To: apmail-shiro-dev-archive@shiro.apache.org Received: (qmail 77641 invoked by uid 500); 6 Jun 2012 19:12:24 -0000 Mailing-List: contact dev-help@shiro.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@shiro.apache.org Delivered-To: mailing list dev@shiro.apache.org Received: (qmail 77302 invoked by uid 99); 6 Jun 2012 19:12:23 -0000 Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Jun 2012 19:12:23 +0000 Received: from isssues-vm.apache.org (localhost [127.0.0.1]) by issues-vm (Postfix) with ESMTP id D46381402B8 for ; Wed, 6 Jun 2012 19:12:23 +0000 (UTC) Date: Wed, 6 Jun 2012 19:12:23 +0000 (UTC) From: "Jared Bunting (JIRA)" To: dev@shiro.apache.org Message-ID: <932886216.44534.1339009943872.JavaMail.jiratomcat@issues-vm> In-Reply-To: <1426996441.42392.1338954623528.JavaMail.jiratomcat@issues-vm> Subject: [jira] [Updated] (SHIRO-369) Guice integration property setting doesn't always work MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SHIRO-369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jared Bunting updated SHIRO-369: -------------------------------- Component/s: Integration: Guice > Guice integration property setting doesn't always work > ------------------------------------------------------ > > Key: SHIRO-369 > URL: https://issues.apache.org/jira/browse/SHIRO-369 > Project: Shiro > Issue Type: Bug > Components: Integration: Guice > Affects Versions: 1.2.0 > Reporter: Jared Bunting > Assignee: Jared Bunting > > The mechanism to allow the setting of arbitrary properties on shiro objects in Guice doesn't always work and sometimes require a workaround. The workaround is to explicitly bind the class that you want the property to be set upon in the ShiroModule. This is less than ideal. > I believe that the issue is because the type listener that does the property setting is bound in the private module, meaning that it only affects beans bound in that private module. However, when bindings to classes aren't made specifically in the private module, they occur as just-in-time bindings, which are effectively bound at the root binder. Therefore, the type listener never gets to see these bindings. > I believe that the solution is to bind all shiro objects in the ShiroModule (and ShiroWebModule as appropriate). This will cause them to always be bound within the private module. To ensure that this is effective, we will also require a test case that scans the classpath for implementations of particular interfaces and ensures that they are bound. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira