Mailing-List: contact dev-help@shiro.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@shiro.apache.org
Date: Mon, 28 May 2012 16:22:22 +0000 (UTC)
From: "Ben Johnson (JIRA)" <jira@apache.org>
To: dev@shiro.apache.org
Message-ID: <1973096098.8852.1338222143272.JavaMail.jiratomcat@issues-vm>
In-Reply-To: <148713249.8791.1338221903715.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Commented] (SHIRO-368) DomainPermission(string, string)
 constructor sets targets to the same value as actions
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/SHIRO-368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284459#comment-13284459 ] 

Ben Johnson commented on SHIRO-368:
-----------------------------------

Patch based on code in 1.2.1 branch
                
> DomainPermission(string, string) constructor sets targets to the same value as actions
> --------------------------------------------------------------------------------------
>
>                 Key: SHIRO-368
>                 URL: https://issues.apache.org/jira/browse/SHIRO-368
>             Project: Shiro
>          Issue Type: Bug
>          Components: Authorization (access control) 
>    Affects Versions: 1.2.0
>         Environment: Windows XP SP3, Intel Core2 Duo
>            Reporter: Ben Johnson
>            Priority: Minor
>         Attachments: DomainPermission.java, DomainPermissionTest.java
>
>
> The DomainPermission(string, string) constructor incorrectly sets the 'targets' field to the value supplied for 'actions':
> 055        public DomainPermission(String actions, String targets) {
> 056            this.domain = getDomain(getClass());
> 057            this.actions = StringUtils.splitToSet(actions, SUBPART_DIVIDER_TOKEN);
> 058            this.targets = StringUtils.splitToSet(actions, SUBPART_DIVIDER_TOKEN);
> 059            encodeParts(this.domain, actions, targets);
> 060        }

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira