Return-Path: X-Original-To: apmail-shiro-dev-archive@www.apache.org Delivered-To: apmail-shiro-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EE0559EAF for ; Thu, 19 Jan 2012 22:12:38 +0000 (UTC) Received: (qmail 22080 invoked by uid 500); 19 Jan 2012 22:12:38 -0000 Delivered-To: apmail-shiro-dev-archive@shiro.apache.org Received: (qmail 21986 invoked by uid 500); 19 Jan 2012 22:12:38 -0000 Mailing-List: contact dev-help@shiro.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@shiro.apache.org Delivered-To: mailing list dev@shiro.apache.org Received: (qmail 21978 invoked by uid 99); 19 Jan 2012 22:12:38 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Jan 2012 22:12:38 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of jared.bunting@peachjean.com designates 209.85.213.173 as permitted sender) Received: from [209.85.213.173] (HELO mail-yx0-f173.google.com) (209.85.213.173) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Jan 2012 22:12:30 +0000 Received: by yenl8 with SMTP id l8so312721yen.32 for ; Thu, 19 Jan 2012 14:12:09 -0800 (PST) Received: by 10.236.193.41 with SMTP id j29mr42705457yhn.12.1327011127017; Thu, 19 Jan 2012 14:12:07 -0800 (PST) Received: from [10.0.0.165] ([174.46.125.162]) by mx.google.com with ESMTPS id y14sm2010938anm.10.2012.01.19.14.12.05 (version=SSLv3 cipher=OTHER); Thu, 19 Jan 2012 14:12:06 -0800 (PST) Message-ID: <4F189534.3000202@peachjean.com> Date: Thu, 19 Jan 2012 16:12:04 -0600 From: Jared Bunting User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1 MIME-Version: 1.0 To: dev@shiro.apache.org Subject: Re: [VOTE] Release Apache Shiro 1.2.0 (2nd attempt) References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit In general, I am a fan of this pattern. I am definitely a fan of tagging an entire trunk and if we have multiple pieces with different release cycles, they would exist in separate trunks. +1 on the release. On 01/19/2012 03:51 PM, Les Hazlewood wrote: > I was trying to be consistent with the actual release version number, > since that is most relevant when perhaps needing to do a checkout (or > perusal) from SVN at a later date. The 'shiro-root' prefix is a > side-effect of maven, not something that should be reflected in SVN > IMO. > > i.e. I find this much better: > > trunk > branches/1.2.x > branches/1.3.x > tags/1.1.0 > tags/1.2.0 > tags/1.2.1 > etc > > This is much nicer and consistent than something that could change > based on pom configuration IMO. > > Is the existing tag something that would prevent you from voting? I'd > _really_ not want to do another release again (which I think I'd have > to do to ensure the maven tags are consistent, right?). I've > spent 4+ hours on this process already (fighting with the site plugin, > gpg, re-releasing, etc) :/ > > Les > > P.S. I do agree that we should be consistent - my hope is that we can > formalize this consistency after this release. I just didn't think it > was a big deal at the time I guess. > > On Thu, Jan 19, 2012 at 12:30 PM, Kalle Korhonen > wrote: >> What was the reason to rename the tag? If we ever have independently >> releasable modules, it gets confusing because the tag doesn't >> immediately tell you for which module it is. If you don't like the >> shiro-root name, let's change the module name, rather than omit it >> from the tag. I'd prefer renaming the tag to shiro-root-1.2.0 for >> consistency. Binaries are ok. >> >> Kalle >> >> >> On Thu, Jan 19, 2012 at 11:39 AM, Les Hazlewood wrote: >>> This is a call to vote in favor of releasing Apache Shiro version 1.2.0. >>> >>> The 59 issues solved for 1.2.0 (since the 1.1.0 release): >>> >>> https://issues.apache.org/jira/secure/IssueNavigator!executeAdvanced.jspa?jqlQuery=project+%3D+SHIRO+AND+fixVersion+%3D+%221.2.0%22+AND+%28status+%21%3D+Open+and+status+%21%3D+%22In+Progress%22%29+ORDER+BY+priority+DESC&runQuery=true&clear=true >>> >>> The tag to be voted upon: >>> https://svn.apache.org/repos/asf/shiro/tags/1.2.0 >>> >>> Staging repo for binaries: >>> https://repository.apache.org/content/repositories/orgapacheshiro-102 >>> >>> Project website (just for informational purposes, not to be voted upon): >>> http://shiro.apache.org/ >>> and maven static generated site (for informational purposes, not to be >>> voted upon): >>> people.apache.org:/www/shiro.apache.org/static/1.2.0 or >>> http://shiro.apache.org/static/1.2.0 once it propagates to web servers >>> >>> Guide to testing staged releases: >>> http://maven.apache.org/guides/development/guide-testing-releases.html >>> >>> Vote open for 72 hours. Please do examine the source and binaries before voting. >>> >>> [ ] +1 >>> [ ] +0 >>> [ ] -1 (please include reasoning)