shiro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Manoj Khangaonkar <khangaon...@gmail.com>
Subject Re: WildCardPermission toString method implementation
Date Thu, 04 Aug 2011 21:17:13 GMT
More complete example.

@Test
  public void WildCardPermission() {
	
	  WildcardPermission p1 = new WildcardPermission("File:r,w,x:myfile") ;
	
	  String s1 = p1.toString();
	  System.out.println(s1) ;
	
	  WildcardPermission p2 = new WildcardPermission(s1) ;
	  String s2 = p2.toString() ;
	  System.out.println(s2) ;
	
	  Assert.assertTrue(p1.implies(p2)) ;
  }

This test should pass. But it fails.

On Thu, Aug 4, 2011 at 2:07 PM, Manoj Khangaonkar <khangaonkar@gmail.com> wrote:
> Hi,
>
> The code
>
> WildcardPermission p1 = new WildcardPermission("File:r,w,x:myfile") ;
> System.out.println(p1.toString()) ;
>
> prints out [file]:[r, w, x]:[myfile]
>
> I was expecting File:r,w,x:myfile which is the String I passed in the
> construction.
>
> Is this by design or is this just a bug ?
>
> I feel toString should return the String passed in via the constructor
> or by calling setParts.
>
> toString needs to return parts in the same format that
> WildCardPermission expects which is
>
> part:part:part.....
>
> where each part could be subpart,subpart,subpart
>
> The brackets are being printed because the implementation does
>
> buffer.append(part);
>
> where part is a Set.
>
> The current implementation is a problem if I call toString and then
> persist the permission as a String to
> the a database. Each part will have a bracket around it.
>
> Let me know if I should open a JIRA.
>
> Manoj
>
>
>
> --
> http://khangaonkar.blogspot.com/
>



-- 
http://khangaonkar.blogspot.com/

Mime
View raw message