shiro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Phil Steitz <phil.ste...@gmail.com>
Subject Re: DomainPermission question
Date Wed, 22 Jun 2011 21:55:06 GMT
On 6/22/11 12:40 PM, Les Hazlewood wrote:
> Hi Phil,
>
> Yep, you're right - the problems you're seeing are definitely bugs.
> Can you please open a Jira issue for this?

Will do, and once I get it working and have a better idea what I am
doing, I will add a patch.
> As for 'DomainPermission' - it was added a while ago (1.0) without
> much support added for it (i.e. there is no 'DomainPermissionResolver'
> or anything like that).  I think it was a class that slipped in to the
> API without being vetted much.

Nothing like "code that can be improved" to get people involved. 
Worked on me - he he.
> Anyway, that class exists because I was toying around with it as a
> concept based on permission classes I had used in my own projects that
> stored these things in a data store.  So it is rooted in real-world
> apps, but the current incarnation isn't ready (obviously, given the
> bugs that you've found).
>
> What it is good for at the moment (at least until the bugs are fixed)
> is more of an example of how you might construct your own Permission
> class.

That's what I am trying to do.  I'll open a JIRA and add comments to
the ticket. 

Thanks!

Phil
> Finally, in my own projects, I've renamed this to be a
> 'ResourcePermission', since the name 'domain' is a little abstract -
> most permissions reflect protecting resources (books, files,
> documents, users, etc) rather than a 'domain' (whatever that may
> mean).
>
> HTH,
>


Mime
View raw message