shiro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Les Hazlewood (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SHIRO-307) DomainPermission does not fully support domain, actions and targets properties
Date Thu, 23 Jun 2011 23:16:47 GMT

    [ https://issues.apache.org/jira/browse/SHIRO-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054169#comment-13054169
] 

Les Hazlewood commented on SHIRO-307:
-------------------------------------

Hi Phil,

I applied the patch and made some modifications - namely:

- Allow DomainPermission to have null values (one or two constructors allowed null values,
so I made this assumption throughout the class).
- Minor modifications to String-related split/toString support to be more congruent with other
similar methods in StringUtils (return a value instead of accept an argument, etc).

Do you see any issues with this based on your testing?  Any objections?

> DomainPermission does not fully support domain, actions and targets properties
> ------------------------------------------------------------------------------
>
>                 Key: SHIRO-307
>                 URL: https://issues.apache.org/jira/browse/SHIRO-307
>             Project: Shiro
>          Issue Type: Bug
>          Components: Authorization (access control) 
>    Affects Versions: 1.0.0, 1.1.0
>            Reporter: Phil Steitz
>            Assignee: Les Hazlewood
>         Attachments: DomainPermission.patch
>
>
> Per the class javadoc, DomainPermission is designed to be a base class for Permission
implementations that persist permission parts as separate properties.  It defines private
fields for domain, actions and targets and exposes getters/setters for these, but the setParts
and constructor methods that set Permission state do not call the property setters and the
property setters don't call setParts.   Property synchronization needs to be added to this
class.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message