shiro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "YangL (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (SHIRO-303) DefaultWebSecurityManager isHttpSessionMode() may be error
Date Thu, 09 Jun 2011 14:03:58 GMT

     [ https://issues.apache.org/jira/browse/SHIRO-303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

YangL closed SHIRO-303.
-----------------------

    Resolution: Not A Problem

> DefaultWebSecurityManager isHttpSessionMode() may be error
> ----------------------------------------------------------
>
>                 Key: SHIRO-303
>                 URL: https://issues.apache.org/jira/browse/SHIRO-303
>             Project: Shiro
>          Issue Type: Bug
>          Components: Web
>    Affects Versions: 1.1.0
>         Environment: isHttpSessionMode()  in org.apache.shiro.web.mgt.DefaultWebSecurityManager.java

>            Reporter: YangL
>              Labels: build
>             Fix For: 1.2.0
>
>   Original Estimate: 12h
>  Remaining Estimate: 12h
>
>  /** 
>      * @since 1.0 
>      */ 
>     public boolean isHttpSessionMode() { 
>         return this.sessionMode == null || this.sessionMode.equals(HTTP_SESSION_MODE);

>     } 
> ---------------------------------------------------------------------------------------

> may be error,and i think this method should as bellow: 
>   public boolean isHttpSessionMode() { 
>         String sm = getSessionMode(); 
>         return (sm!= null && sm.equals(HTTP_SESSION_MODE)); 
>     } 
>  

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message