Return-Path: Delivered-To: apmail-shiro-dev-archive@www.apache.org Received: (qmail 71514 invoked from network); 12 Oct 2010 06:54:06 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 12 Oct 2010 06:54:06 -0000 Received: (qmail 87092 invoked by uid 500); 12 Oct 2010 06:54:06 -0000 Delivered-To: apmail-shiro-dev-archive@shiro.apache.org Received: (qmail 87037 invoked by uid 500); 12 Oct 2010 06:54:05 -0000 Mailing-List: contact dev-help@shiro.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@shiro.apache.org Delivered-To: mailing list dev@shiro.apache.org Received: (qmail 87029 invoked by uid 99); 12 Oct 2010 06:54:05 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Oct 2010 06:54:05 +0000 X-ASF-Spam-Status: No, hits=0.7 required=10.0 tests=RCVD_IN_DNSWL_NONE,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [209.85.214.173] (HELO mail-iw0-f173.google.com) (209.85.214.173) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Oct 2010 06:53:59 +0000 Received: by iwn34 with SMTP id 34so2857623iwn.32 for ; Mon, 11 Oct 2010 23:53:38 -0700 (PDT) MIME-Version: 1.0 Received: by 10.42.135.138 with SMTP id p10mr161051ict.346.1286866418264; Mon, 11 Oct 2010 23:53:38 -0700 (PDT) Sender: les.hazlewood@anjinllc.com Received: by 10.231.208.77 with HTTP; Mon, 11 Oct 2010 23:53:37 -0700 (PDT) In-Reply-To: <20101012042233.279502388A2C@eris.apache.org> References: <20101012042233.279502388A2C@eris.apache.org> Date: Mon, 11 Oct 2010 23:53:37 -0700 X-Google-Sender-Auth: E1M9jW1Hmi0KjkfwAnAKgkvbIYw Message-ID: Subject: Re: svn commit: r1021622 - /shiro/trunk/web/src/main/java/org/apache/shiro/web/util/RedirectView.java From: Les Hazlewood To: dev@shiro.apache.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Yeah, I made the 2.x comment a day or two ago because changing the method signature means that it would not be a backwards compatible change. I highly doubt that anyone subclassed RedirectView to override that method since this class is pretty much used for our own internal needs, but if we go forward with this change, I think it needs to be specified in the RELEASE_NOTES.txt file at the root of the project to ensure it is well documented (and then merged with the complete release notes for a release). My .02, Les On Mon, Oct 11, 2010 at 9:22 PM, wrote: > Author: kaosko > Date: Tue Oct 12 04:22:32 2010 > New Revision: 1021622 > > URL: http://svn.apache.org/viewvc?rev=3D1021622&view=3Drev > Log: > RESOLVED - issue SHIRO-191: Change all StringBuffer usages to StringBuild= er > https://issues.apache.org/jira/browse/SHIRO-191 > - Fixed the only remaining use of StringBuffer (Javadoc stated the fix is= for 2.x and comments talk about JDK 1.3 compatibility which is likely not = relevant anymore) > > Modified: > =C2=A0 =C2=A0shiro/trunk/web/src/main/java/org/apache/shiro/web/util/Redi= rectView.java > > Modified: shiro/trunk/web/src/main/java/org/apache/shiro/web/util/Redirec= tView.java > URL: http://svn.apache.org/viewvc/shiro/trunk/web/src/main/java/org/apach= e/shiro/web/util/RedirectView.java?rev=3D1021622&r1=3D1021621&r2=3D1021622&= view=3Ddiff > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- shiro/trunk/web/src/main/java/org/apache/shiro/web/util/RedirectView.= java (original) > +++ shiro/trunk/web/src/main/java/org/apache/shiro/web/util/RedirectView.= java Tue Oct 12 04:22:32 2010 > @@ -191,7 +191,7 @@ public class RedirectView { > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Map model, HttpServletRequest r= equest, HttpServletResponse response) throws IOException { > > =C2=A0 =C2=A0 =C2=A0 =C2=A0 // Prepare name URL. > - =C2=A0 =C2=A0 =C2=A0 =C2=A0StringBuffer targetUrl =3D new StringBuffer(= ); > + =C2=A0 =C2=A0 =C2=A0 =C2=A0StringBuilder targetUrl =3D new StringBuilde= r(); > =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (this.contextRelative && getUrl().startsWi= th("/")) { > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 // Do not apply context path to= relative URLs. > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 targetUrl.append(request.getCon= textPath()); > @@ -214,12 +214,8 @@ public class RedirectView { > =C2=A0 =C2=A0 =C2=A0* @see #urlEncode > =C2=A0 =C2=A0 =C2=A0* @see #queryProperties > =C2=A0 =C2=A0 =C2=A0* @see #urlEncode(String, String) > - =C2=A0 =C2=A0 * @deprecated this method accepts a less-than-ideal Strin= gBuffer argument and will be replaced by > - =C2=A0 =C2=A0 * a StringBuilder argument in the next major version (2.x= ) of Shiro. =C2=A0It remains in place to retain > - =C2=A0 =C2=A0 * 1.0 -> 1.1 backwards compatibility. =C2=A0See SHIRO-196. > =C2=A0 =C2=A0 =C2=A0*/ > - =C2=A0 =C2=A0@Deprecated > - =C2=A0 =C2=A0protected void appendQueryProperties(StringBuffer targetUr= l, Map model, String encodingScheme) > + =C2=A0 =C2=A0protected void appendQueryProperties(StringBuilder targetU= rl, Map model, String encodingScheme) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 throws UnsupportedEncodingExcep= tion { > > =C2=A0 =C2=A0 =C2=A0 =C2=A0 // Extract anchor fragment, if any. > > >