Mailing-List: contact shiro-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: shiro-dev@incubator.apache.org
Received-SPF: pass (nike.apache.org: domain of kalle.o.korhonen@gmail.com
 designates 209.85.212.47 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:date:message-id:subject:from:to:content-type;
        b=VjGjyXNVNi6oqyvKRRkKpNHLJnA6KCULXQFC6sIMcQxyWrGirLKaqaFL780ZwVqq8P
         v07L1+92Z63OKfivn3Zc/DuF6RuJVqS6jxzq/BA/wxdfIi5ZPoVi2Hvh2GPLVYSIWjnq
         5B3kN1FLP2LNoNeWFgzDQhe7eB8g+WXA0VUZU=
MIME-Version: 1.0
Date: Fri, 25 Jun 2010 13:24:34 -0700
Message-ID: <AANLkTikZZG2iAFnFJCTG7LPu8kVrmWVhTC5fMXfQAPez@mail.gmail.com>
Subject: Proposed changes to Shiro annotations
From: Kalle Korhonen <kalle.o.korhonen@gmail.com>
To: shiro-dev@incubator.apache.org
Content-Type: text/plain; charset=ISO-8859-1

Related to https://issues.apache.org/jira/browse/SHIRO-175 and some of
the Shiro extensions we (Tynamo.org) have made, I'd like to change
@Target(ElementType.METHOD) of all annotations to
@Target({ElementType.TYPE, ElementType.METHOD}). The obvious semantics
of attaching a security annotation to a class is that the same
permission would apply to all method invocations in that class.

SHIRO-175 suggests that we'd deprecate the existing annotations in
favor of RequiresAnyXXX and RequiresAllXXX annotations, forcing to
target 1.1 release for the issue resolution. We could also keep the
existing annotations and pick either ANY or ALL semantics in order to
avoid deprecating anything - not sure which one is better. The current
semantics are unclear, the Javadoc implies ANY for RequiresRoles but
ALL for RequiresPermissions.

Here's what I'd suggest:
- 1.0.1 change @Target to apply to TYPEs as well, fix ambiguity of
current annotations (especially if we decide to keep them)
- 1.1.0 resolve SHIRO-175 and add RequiresAnyXXX and RequiresAllXXX
annotations (and deprecate existing annotations if we choose to do so)

I can handle implementing the changes. Any comments?

Kalle